[firebirdsql] new port

[asfernandes]

• Changes comply with the maintainer guide
• The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
• Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
• The versioning scheme in vcpkg.json matches what upstream says.
• The license declaration in vcpkg.json matches what upstream says.
• The installed as the "copyright" file matches what upstream says.
• The source code of the component installed comes from an authoritative source.
• The generated "usage text" is accurate. See adding-usage for context.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is in the new port's versions file.
• Only one version is added to each modified port's versions file.

[asfernandes]

@microsoft-github-policy-service agree

[dg0yt]

Did you at least try to use vcpkg_configure_make?

[asfernandes]

Did you at least try to use vcpkg_configure_make?

Could you be more specific? For what?

[Neumann-A]

The question is rather why it is not using vcpkg_cmake_configure

[asfernandes]

The question is rather why it is not using vcpkg_cmake_configure

Firebird build procedure is with ./autogen.sh, not ./configure.

[Neumann-A]

Maintainer guidelines say to prefer cmake buildsystem if upstream provides it (unless it is useless for some reason)

[asfernandes]

Maintainer guidelines say to prefer cmake buildsystem if upstream provides it (unless it is useless for some reason)

Firebird has useless cmake files, used by single contributor in the past and now completely unmaitained.

[Neumann-A]

Then the question becomes why are you not using vcpkg_configure_make. You are completely missing the compiler flags setup.

[asfernandes]

Then the question becomes why are you not using vcpkg_configure_make. You are completely missing the compiler flags setup.

I may check it.

I based the port in libtomcrypt/libtommath, and both are calling making with vcpkg_execute_build_process too.

[dg0yt]

Firebird build procedure is with ./autogen.sh, not ./configure.

This autogen.sh doesn't do much more than autoreconf and configure. As does
vcpkg_configure_make(... AUTOCONFIG ...).

[asfernandes]

Firebird needs to execute configure in the same directory as the sources are. It looks like vcpkg_configure_make runs it out of tree.

[dg0yt]

Out-of-tree is good practice. For the bad guys, there is option COPY_SOURCE.

[asfernandes]

Out-of-tree is good practice. For the bad guys, there is option COPY_SOURCE.

Done, thanks.

[dg0yt]

These libs have ports in vcpkg, so the builtins shouldn't be used.

[dg0yt]

This library has a port in vcpkg. And there is more than static linkage.

[dg0yt]

Not sure if this should be hard-coded.

[dg0yt]

This really asks for trouble with regard to these libs' ports.

[dg0yt]

linux logs:

configure: error: ICU support not found - please install development ICU package

[asfernandes]

linux logs:

configure: error: ICU support not found - please install development ICU package

Firebird always uses ICU through dynamic loading (dlopen / LoadLibrary).

Is it possible to force this dependency to be built as shared libraries / DLLs?

[dg0yt]

Is it possible to force this dependency to be built as shared libraries / DLLs?

Not in triplets which mandate static linkage.
Basically the user decides. Not a single port like firebirdsql.

[MonicaLiu0311]

Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review".

[MonicaLiu0311]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[MonicaLiu0311]

Please get failure logs here of x64-windows.

-- Using source at D:/b/firebird/src/v5.0.0-b04904ce0c.clean
CMake Error at ports/firebird/windows/portfile.cmake:19 (file):
  file INSTALL cannot find
  "D:/b/firebird/src/v5.0.0-b04904ce0c.clean/output_x64_release/include": No
  error.
Call Stack (most recent call first):
  ports/firebird/portfile.cmake:12 (include)
  scripts/ports.cmake:172 (include)


error: building firebird:x64-windows failed with: BUILD_FAILED

Please get failure logs here of x64-linux.

[MonicaLiu0311]

@asfernandes Is there any new progress?