Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skia] add feature rtti #36712

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omartijn
Copy link
Contributor

This is necessary on UNIX platforms when using the skia library in an application built with rtti itself.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
This is necessary on UNIX platforms when using the skia library in an
application built with rtti itself.
@dg0yt
Copy link
Contributor

dg0yt commented Feb 14, 2024

Is this really a feature or a triplet setting?

@data-queue data-queue marked this pull request as draft February 14, 2024 23:05
@omartijn
Copy link
Contributor Author

Is this really a feature or a triplet setting?

I think having this as a triplet setting is quite a nice idea, and I support that as an idea.

However, we already have other ports that have this as a feature, e.g. llvm, glslang, bullet3, mesa, halide`. For consistency, I'd argue we merge it like this for now.

If we turn this into a triplet-feature we also need to ensure it's properly supported for all ports, which I think is quite a bit of work, so I think that deserves it's own PR.

@dg0yt
Copy link
Contributor

dg0yt commented Feb 15, 2024

At least I'm surprised to see EXTRA_CXX_CFLAGS getting quick "approval", despite the usual "follow CMake toolchain settings". Add did you check that there isn't some explicit gn config stuff? Does the flag depend on actual compiler?

@dg0yt
Copy link
Contributor

dg0yt commented Feb 16, 2024

Is this specific to clang, llvm/llvm-project#66117?

@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 18, 2024
@FrankXie05 FrankXie05 changed the title Add rtti support to SKIA Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
5 participants