Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qtmultimedia] Add restriction feature ffmpeg does not support Linux #36983

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimwang118
Copy link
Contributor

Fixes #36429

ffmpeg requires libva to build on Linux, but currently there is no such port in vcpkg, so the build fails. Therefore add the restriction that ffmpeg does not support building on Linux.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

This feature passed with following triplets:

x64-windows
x64-linux
@jimwang118 jimwang118 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Feb 27, 2024
@Neumann-A
Copy link
Contributor

ffmpeg requires libva to build on Linux, but currently there is no such port in vcpkg, so the build fails. Therefore add the restriction that ffmpeg does not support building on Linux

that just means libva needs to be system provided for now. That does not rectify using supports!

@jimwang118
Copy link
Contributor Author

that just means libva needs to be system provided for now. That does not rectify using supports!

Does this mean that I need to tell the user that he needs to install libva manually before installing feature ffmpeg?

@dg0yt
Copy link
Contributor

dg0yt commented Feb 27, 2024

... similar to all the x packages ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team.
4 participants