-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sparrow] Add sparrow
#37221
base: master
Are you sure you want to change the base?
[sparrow] Add sparrow
#37221
Conversation
acd27e1
to
9effd34
Compare
2d9463c
to
90178d3
Compare
2b3c442
to
3b4c929
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
The usage test passed on
|
Thank you, @MonicaLiu0311. |
This does not seem to be correct. This project is not associated with Would you accept xtensor-stack-sparrow ? |
|
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
The thing is that |
Can't we just rename the port if/when that happens? |
Does renaming the port makes the old name available again? If so, could name this port |
No, in general people would have to update their references. But they'd have to do that referencing the github repo in the first place. |
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
As `date` does not supports it. See: https://github.com/microsoft/vcpkg/blob/master/ports/date/vcpkg.json#L21 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Hello @BillyONeal, The project has been transferred to another organization, and this PR is now ready for another review. 🙂 |
The naming concern remains. Would you accept |
Can we actually reconsider |
I would love this to be named sparrow. It would save us the trouble of having to tell people to use a different name on vcpkg. |
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
The problem with the name sparrow is again, not in repology, and search hits lead to
which are not this. |
@AugP We affirm what we said back in March, there's too much potential for confusion and we want the name to be |
Ping @jjerphan |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.