Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elements] Update port #38188

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[elements] Update port #38188

wants to merge 2 commits into from
+29 −7

Conversation

ex-purple
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
@ex-purple ex-purple force-pushed the elements branch 2 times, most recently from 0e5f4cf to 4063f9f Compare April 14, 2024 23:50
@ex-purple
Copy link
Contributor Author

config-x64-windows-out.log:

 Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)

How do I add pkg-config to the build? 🤔
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Apr 15, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Apr 15, 2024 

vcpkg_find_acquire_program(PKGCONFIG)
...
vcpkg_cmake_configure(...
    OPTIONS
        "-DPKG_CONFIG_EXECUTABLE=${PKGCONFIG}"
)
@Cheney-W
Copy link
Contributor

Cheney-W commented Apr 15, 2024 •
edited
Loading

@ex-purple Could you please apply dg0yt's comment to fix the error in CI?
@Cheney-W Cheney-W marked this pull request as draft April 15, 2024 07:02
@ex-purple ex-purple marked this pull request as ready for review April 16, 2024 19:02
@ex-purple
Copy link
Contributor Author

ex-purple commented Apr 16, 2024 •
edited
Loading

@ex-purple Could you please apply dg0yt's comment to fix the error in CI?

Done

I have no idea what is a problem now
@Cheney-W
Copy link
Contributor 

warning: The following binaries should use the Dynamic Debug (/MDd) CRT.
  D:\p\elements_x86-windows\debug\lib\elements.lib links with: Static Debug (/MTd)
To inspect the lib files, use:
  dumpbin.exe /directives mylibfile.lib
warning: The following binaries should use the Dynamic Release (/MD) CRT.
  D:\p\elements_x86-windows\lib\elements.lib links with: Static Release (/MT)
To inspect the lib files, use:
  dumpbin.exe /directives mylibfile.lib
error: Found 2 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: D:\a\_work\1\s\ports\elements\portfile.cmake
error: building elements:x86-windows failed with: POST_BUILD_CHECKS_FAILED
@ex-purple
Copy link
Contributor Author

The following binaries should use the Dynamic Debug (/MDd) CRT.
The following binaries should use the Dynamic Release (/MD) CRT.

What does it mean?
Cheney-W
Cheney-W reviewed Apr 19, 2024
View reviewed changes
ports/elements/fix-linkage.patch
Comment on lines +9 to +10
-add_library(elements STATIC)
+add_library(elements)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is building statically an upstream setting, so are they okay with the modifications here?
ports/elements/portfile.cmake
)

vcpkg_cmake_build()

file(INSTALL "${SOURCE_PATH}/lib/include/elements.hpp" DESTINATION "${CURRENT_PACKAGES_DIR}/include")
file(INSTALL "${SOURCE_PATH}/lib/include/elements" DESTINATION "${CURRENT_PACKAGES_DIR}/include")
file(INSTALL "${SOURCE_PATH}/lib/infra/include/infra" DESTINATION "${CURRENT_PACKAGES_DIR}/include")
file(INSTALL "${SOURCE_PATH}/resources" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the files in resources folder used for?
ports/elements/portfile.cmake
HEAD_REF master
PATCHES
asio-headers.patch
win-find-libraries.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this patch is no longer needed, please remove the files accordingly.
@Cheney-W Cheney-W marked this pull request as draft April 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
3 participants
@ex-purple @dg0yt @Cheney-W