-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[octave] add new port #38243
base: master
Are you sure you want to change the base?
[octave] add new port #38243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just first feedback.
Too early to decide on spending more time on this PR.
ports/octave/vcpkg.json
Outdated
"description": "High-level interpreted language, primarily intended for numerical computations.", | ||
"homepage": "https://octave.org/", | ||
"license": "GPL-3.0-or-later", | ||
"supports": "linux & !static", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This disables all vcpkg CI coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but I only succeeded to compile this port with vcpkg on dynamic ubuntu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not allowed for the following reasons:
- Currently, the official Linux we support is statically built. Your expression will cause our CI to be unable to detect and run. triplets/x64-linux.cmake:
set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE static)
set(VCPKG_CMAKE_SYSTEM_NAME Linux)
- I found that the upstream supports
windows & linux & osx
. In this case,"support"
should be consistent with the upstream. You can write the failed triplets intoci.baselin.txt
:
I admit that needed more work to compile this port on more triplets. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Ping @talregev |
@MonicaLiu0311 Thank you for your review. |
30a0cfa
to
5e02f69
Compare
@MonicaLiu0311 |
I will try to patch and remove this error and see what will happen. |
After reading the issue mentioned in configure.ac, it seems that this port os a candidate for
|
97810bf
to
7d67b2f
Compare
Revert the port to be non static. |
@talregev Is there any new progress? |
for me, I finished develop this port. If you want to review, go ahead, and let me know what you think. |
There must be at least one CI configuration which builds the port. |
@dg0yt Do you want to try this? You can use my commits. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.