Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gettext-libintl] Changes to allow compiling osx with osxcross #38374

Closed
wants to merge 4 commits into from
Closed

[gettext-libintl] Changes to allow compiling osx with osxcross #38374

wants to merge 4 commits into from

Conversation

nonameentername
Copy link

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
dg0yt
dg0yt reviewed Apr 24, 2024
View reviewed changes
ports/gettext-libintl/portfile.cmake
Comment on lines +80 to +82
if(VCPKG_TARGET_IS_OSX AND VCPKG_CROSSCOMPILING)
list(APPEND OPTIONS --host ${TARGET_TRIPLET}-darwin)
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't code for the specific port but for scripts/vcpkg_configure_make.cmake. (Which is more expensive to change, affecting all triplets and many ports.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @nonameentername
@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 24, 2024
@MonicaLiu0311 MonicaLiu0311 reopened this May 28, 2024
@dg0yt
Copy link
Contributor

dg0yt commented May 28, 2024

@MonicaLiu0311 IMO you shouldn't update the branch as long as the PR is understood as taking the wrong road. Rebuilding gettext-libintl is expensive. And this rebuild hit CI in a high-load time.
@MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 IMO you shouldn't update the branch as long as the PR is understood as taking the wrong road. Rebuilding gettext-libintl is expensive. And this rebuild hit CI in a high-load time.

The remaining triplets have been cancelled, and this PR will be closed if there is no response next week.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
3 participants
@nonameentername @dg0yt @MonicaLiu0311