Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dcmtk] Detect failing find_package command #38932

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevle
Copy link
Contributor

@kevle kevle commented May 24, 2024

Fixes #38476

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
@kevle kevle changed the title [dcmtk] Detect failing find_package May 24, 2024
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label May 27, 2024
@kevle
Copy link
Contributor Author

kevle commented May 27, 2024

The upstream package detection logic will silently disable features when find_package is not successful in locating the package, this PR tries to make failure visible in CI.

Conan has implemented a similar patch: conan-io/conan-center-index@537270a#diff-830f024c7e10cb4d4700e51f47d6d81ee7e1043aad772b91c943f14d8cda64a2

I am still trying to reproduce #38476 in order to verify that this PR will actually resolve the issue.

@dg0yt
Copy link
Contributor

dg0yt commented May 27, 2024

Instead of using a patch, this could be mostly solved from the portfile by adding

    <feature>    CMAKE_REQUIRE_FIND_PACKAGE_<Pkg>

to vcpkg_check_features.
(And probably they also need to be added to the maybe-unused list.)

@kevle kevle force-pushed the dcmtk-find-package-hardening branch from 3c23b0f to 55728a4 Compare June 3, 2024 07:06
@kevle kevle force-pushed the dcmtk-find-package-hardening branch from 55728a4 to c291438 Compare June 3, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
3 participants