[audit] new port

[t43rr7]

• Changes comply with the maintainer guide.
• The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
• Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
• The versioning scheme in vcpkg.json matches what upstream says.
• The license declaration in vcpkg.json matches what upstream says.
• The installed as the "copyright" file matches what upstream says.
• The source code of the component installed comes from an authoritative source.
• The generated "usage text" is accurate. See adding-usage for context.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is in the new port's versions file.
• Only one version is added to each modified port's versions file.

[t43rr7]

@microsoft-github-policy-service agree company="F.A.C.C.T."

[WangWeiLin-MV]

Note: I will be converting your PR to draft status. Please click "Ready for review" after making the fix and modifications.

[WangWeiLin-MV]

Run command vcpkg x-add-version --all --overwrite-version will fix the version database.

[t43rr7]

@WangWeiLin-MV do you have any comments to this PR?

[WangWeiLin-MV]

The port usage tests pass with the following triplets:

• x64-linux

[t43rr7]

@WangWeiLin-MV, do you think that removing the usage file is a good idea? It is usually not clear how to link the library and add the include and build flags to a CMake project with vcpkg for a port that is not a CMake target.

[WangWeiLin-MV]

@t43rr7 After installed, vcpkg will give the heuristics usage #39587 (comment) like that:

libaudit provides pkg-config modules:
    # Libraries needed for apps that use the kernel audit framework
    audit
    # Library for apps that want to parse and interpret audit events
    auparse

[t43rr7]

vcpkg will give the heuristics usage

@WangWeiLin-MV Can you explain how does it work? Just for information. Thanks

[WangWeiLin-MV]

@t43rr7 See here https://github.com/microsoft/vcpkg-tool/blob/2024-06-10/src/vcpkg/commands.install.cpp#L996-L1017 and the vcpkg - PR - 1268

[dg0yt]

Can you explain how does it work?

/share/<PORT>/usage is for vcpkg install <pkg>. If a port doesn't install that file, vcpkg has heuristics which look for CMake config and pkg-config files, and it prints generated usage info. For pkg-config, it is pretty accurate.

[dg0yt]

(Community feedback)

[dg0yt]

Suggested change

vcpkg_check_linkage(ONLY_STATIC_LIBRARY)

Similar to libcgroup, this shouldn't be there if it is not an upstream restriction.

[dg0yt]

FTR there is a liburing port in vcpkg.

[t43rr7]

I didn't try to build audit with io_uring support in this port, but I think that there may be same issues encountered as the were at libcgroup port. So let's keep io_uring unsupported in this port for now.

[JavierMatosD]

As @dg0yt mentioned, it appears that the package is named audit and vcpkg_check_linkage(ONLY_STATIC_LIBRARY) should only be used if it's an actual restriction.

[t43rr7]

@dg0yt @JavierMatosD

Port renamed: libaudit -> audit.
Removed static check.

See commit

[dg0yt]

As just noted in another port:
Run vcpkg format-manifest ports/audit/vcpkg.json. At least the license field uses deprecated identifiers.
Use version-semver it it can be verified that the project uses semantic versioning.

Everything else LGTM 👍

[t43rr7]

Regard semver, I cannot find any proof that audit uses semver. Logically I can assume that it keeps backward compatibility through all versions, because commonly it's a system library-wrapper around kernel API. I also haven't found any notes about versioning system it uses. So, seems like you're right, I'll change version-semver to version.

Run vcpkg format-manifest ports/audit/vcpkg.json. At least the license field uses deprecated identifiers.

I don't understand, what output should I get from this command, but I got nothing.

[dg0yt]

Run vcpkg format-manifest ports/audit/vcpkg.json. At least the license field uses deprecated identifiers.

I don't understand, what output should I get from this command, but I got nothing.

It is primary effect is to create a standardized formatting, so it won't do anything to a properly formatted file.
... but I expected it to also check for deprected licence identifies. I see that this isn't implemented in the tool, only in the GH action at .github/workflows/untrustedPR.yml. You must wait for the workflow, or manually check "Deprecated License Identifiers" at https://spdx.org/licenses/.

[dg0yt]

The GH action did run, but the output is neither complete nor forwarded...

Warning: You have modified or added at least one vcpkg.json where you should check the "license" field.
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/audit/vcpkg.json (has deprecated license "GPL-2.0")

[t43rr7]

The GH action did run, but the output is neither complete nor forwarded...

I fixed the licence

[WangWeiLin-MV]

The port usage tests pass with the following triplets:

• x64-linux
• x64-linux-dynamic

[dg0yt]

LGTM. 👍