Fix setter so IE7/8 can set text of style element #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Document.implement({ | ||
|
|
||
| newElement: function(tag, props){ | ||
| if (props && props.checked != null) props.defaultChecked = props.checked; | ||
|
|
||
| /*<ltIE9>*/ // IE needs the type to be set before changing content of style element | ||
| if (!canChangeStyleHtml && ~tag.indexOf('style')){ |
Setter and Getter for "style" element is special in old IE. This creates exceptions to take care of that.
|
@ibolmo updated! |
| if (!canChangeStyleHTML && tag == 'style'){ | ||
| var styleElement = document.createElement('style'); | ||
| styleElement.setAttribute('type', 'text/css'); | ||
| props.type && delete props.type; |
There was a problem hiding this comment.
nit picking, but
if (props.type) delete props.type;
ibolmo
added a commit
that referenced
this pull request
Jul 4, 2014
Fix setter so IE7/8 can set text of style element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2265
Our setters brake old IE when setting text of a style element.
This pull request adds a alternative
propertySetters.textin case the problem exists in the Browser.Used some ideas from @arian's fix on his
fix-2265-text branch.