Scroller fix

[SergioCrisostomo]

fixes #1012, closes #1013

Contrary to the documentation, Scroller Class crashes if window is passed to the Class.

Docs were giving example with window as element. That breaks the code
as described in #1012

This pull request fixes that (source code fix was discussed in #1012, and is included in this p.r.)

This changes also:

• the example in the docs to something one can copy/paste and see
  it working "out of the box": http://jsfiddle.net/v4yJD/
• the first parameter info, from element to mixed, since
  code source uses this.element = document.id(element);

[arian]

Maybe it should work on window?

[SergioCrisostomo]

@arian sure, it could work on window if we changed on L88 to this under:

pos = (this.element != this.docBody && this.element != window) ? this.element.getOffsets() : {x: 0, y:0},

jsFiddle: http://jsfiddle.net/9rmHf/

I would still vote for the new docs example, if you think its ok (keeping window information).
Would you prefer that change instead?

[arian]

I'd prefer that indeed.

[SergioCrisostomo]

@arian: updated

[anutron]

LGTM. Ship it.

[RemkoNolten]

It looks like this fix is currently not properly implemented. In the current version of Mootools More, the line reads:

pos = ((this.element != this.docBody) && (this.element != window)) ? element.getOffsets() : {x: 0, y: 0},

Which throws a ReferenceError: element is not defined.
I think it should be:

pos = ((this.element != this.docBody) && (this.element != window)) ? this.element.getOffsets() : {x: 0, y: 0},

[SergioCrisostomo]

@RemkoNolten i supose you are right. Do you have the possibility to send a pr to fix this, and eventually a spec also?

Thanks

[RemkoNolten]

@SergioCrisostomo To be honest: I've never create a push request and/or a spec before, so it would take me considerable time which I (unfortunately) do not have at the moment. (It's about time I learned :))
If time is no issue, I can maybe look into it in the coming weeks.

[SergioCrisostomo]

@RemkoNolten no problem. I will check this out later today. Do take a look here: https://github.com/mootools/mootools-more#contribute when you find time.

Thank you again!

[RemkoNolten]

@SergioCrisostomo Thanks for your quick response! I've some other patches/fixes (not really bugs) in my version of Mootools which I certainly intend to contribute some day. My lack of knowledge / time is currently prohibiting this, but I will look into the document you suggested soon!

[SergioCrisostomo]

patches are really welcome :)
cheers!

On Wed, Nov 5, 2014 at 11:57 AM, Remko Nolten notifications@github.com
wrote:

@SergioCrisostomo https://github.com/SergioCrisostomo Thanks for your
quick response! I've some other patches/fixes (not really bugs) in my
version of Mootools which I certainly intend to contribute some day. My
lack of knowledge / time is currently prohibiting this, but I will look
into the document you suggested soon!

—
Reply to this email directly or view it on GitHub
#1269 (comment)
.