Fix Drag when no offsetParent #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Drag when no offsetParent - default to false the new "compensateScroll" option - add it in the docs
|
What's the issue? |
| @@ -82,6 +86,7 @@ var Drag = new Class({ | |||
| drag: this.drag.bind(this), | |||
| stop: this.stop.bind(this), | |||
| cancel: this.cancel.bind(this), | |||
| sumValues: this.sumValues.bind(this), | |||
There was a problem hiding this comment.
You don't use this as far as I can see...
|
Looks quite ok I think. |
|
Thank you for feedback @arian. Will check your comments and fix. The issue is that while "onDrag" if scroll happens the dragged element gets out of screen. This is a option to make it stay where the mouse is. |
|
@arian updated. |
|
💥 goes the dynamite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded my largest project to current code (1.5.1-dev) and found a issue I created with the last commit.
While fixing this found also a better logic in the code to be more localized in the Class.
Fixed jsFiddle - drag follows with scroll
Broken jsFiddle - drag do not follow with scroll