String.QueryString: fix bug decoding '+' #1313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decodeURIComponent doesn't do the correct thing with query parameter keys or values. Specifically, it leaves '+' as '+' when it should be converting them to spaces as that's the specification. When browsers submit HTML forms via GET, the values are encoded using the 'application/x-www-form-urlencoded' mime type which converts spaces to '+'. decodeURIComponent() will then give incorrect results on components of the query string. See: http://unixpapa.com/js/querystring.html for a description of the problem.
String.replace only replaces the first occurrence when the search is specified as a string.
|
Thanks @sctice ! |
|
LGTM 👍 |
|
👍 |
SergioCrisostomo
added a commit
that referenced
this pull request
Aug 10, 2015
|
added via 8abfa00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeURIComponent doesn't do the correct thing with query parameter
keys or values. Specifically, it leaves '+' as '+' when it should be
converting them to spaces as that's the specification. When browsers
submit HTML forms via GET, the values are encoded using
the 'application/x-www-form-urlencoded' mime type which converts
spaces to '+'. decodeURIComponent() will then give incorrect results
on components of the query string.
See: http://unixpapa.com/js/querystring.html for a description of the
problem.