Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode launch.json upgrade #5967

Merged
merged 1 commit into from
Apr 29, 2024
Merged

vscode launch.json upgrade #5967

merged 1 commit into from
Apr 29, 2024

Conversation

smithellis
Copy link
Contributor

  • Replace "type": "python" with "type": "debugpy"
  • Add common test patterns for debugging
  • All tests
  • Wiki tests
  • Messages tests
@smithellis
vscode launch.json upgrade
743fe5d 
* Replace "type": "python" with "type": "debugpy"
* Add two common tests for debugging
** All tests
** Wiki tests
** Messages tests
@akatsoulas
Copy link
Collaborator

@smithellis let me know when this is ready for a review
@smithellis smithellis marked this pull request as ready for review April 25, 2024 16:30
escattone
escattone approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very knowledgeable on the vscode dev containers, but this seems fine to me. I tried it locally, and the one thing I had to do was install debugpy in the dev container the first time I ran the Wiki tests via the configuration.
@smithellis smithellis merged commit 106fc31 into mozilla:main Apr 29, 2024
2 checks passed
@smithellis smithellis deleted the vscode-launch-json branch April 29, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@smithellis @akatsoulas @escattone