Corrected tooltip hover information #3270
Conversation
| @@ -369,13 +369,13 @@ history-Translation--span-copied = | |||
| .title = Copied ({ $machinerySources }) | |||
|
|
|||
| history-translation--approved = | |||
| .title = Approved by { $user } on { DATETIME($reviewedDate, dateStyle:"long", timeStyle:"medium") } | |||
| .title = Approved by { $user } on { DATETIME($reviewedDate, month: "long", year: "numeric", day: "numeric", hour: "numeric", minute: "numeric", second: "numeric") } | |||
There was a problem hiding this comment.
What's the purpose of this change?
There was a problem hiding this comment.
This change allows me to print the date without the Weekday as well. Is there a more succinct way of doing this?
There was a problem hiding this comment.
This format looks OK. It's the tooltip shown when you hover the translation creation date that is showing the weekday:
#2763 (comment)
| @@ -196,17 +196,23 @@ export function HistoryTranslationBase({ | |||
|
|
|||
| const review = { | |||
| id: 'history-translation--unreviewed', | |||
| vars: { user: '', reviewedDate: new Date(translation.dateIso) }, | |||
| vars: { user: '', reviewedDate: new Date() }, | |||
There was a problem hiding this comment.
Can we completely drop reviewedDate here?
There was a problem hiding this comment.
Potentially... is there a way for me to pass approvedDate or rejectedDate to the .ftl file if we do remove this variable?
There was a problem hiding this comment.
Ah, I missed that this was part of an FTL message.
There was a problem hiding this comment.
Can we use '' instead of new Date()?
There was a problem hiding this comment.
I seem to get a type error if I try to switch to ''. Should I still try to move forward with using '' instead of new Date()?
There was a problem hiding this comment.
Makes sense. Let's keep new Date().
pontoon/base/views.py
Outdated
| "date": t.date.strftime("%b %d, %Y %H:%M"), | ||
| "date_iso": t.date.isoformat(), |
There was a problem hiding this comment.
We no longer use translation.date on frontend, so we can drop it. We can also drop .isoformat().
At that point we should rename date_iso to date (also on the frontend).
| "date": t.date.strftime("%b %d, %Y %H:%M"), | |
| "date_iso": t.date.isoformat(), | |
| "date": t.date, |
| year: 'numeric', | ||
| month: 'long', | ||
| day: 'numeric', | ||
| hour: 'numeric', | ||
| minute: 'numeric', | ||
| second: 'numeric', |
There was a problem hiding this comment.
To be consistent with the format used for the review timestamp and more concise, let's use this:
| year: 'numeric', | |
| month: 'long', | |
| day: 'numeric', | |
| hour: 'numeric', | |
| minute: 'numeric', | |
| second: 'numeric', | |
| dateStyle: 'long', | |
| timeStyle: 'medium', |
| date={new Date(translation.dateIso)} | ||
| title={`${translation.date} UTC`} | ||
| date={new Date(translation.date)} | ||
| title='' |
There was a problem hiding this comment.
Seems like we can remove the title attribute?
Fix #2763
Made changes to previous pull request to correctly display the last day an action was taken upon a translation. Additionally, removed the Weekday within the information displayed in the tooltip. See #3263 for more context.
Updated Tooltip: