Enhance user action logging #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjazz
reviewed
Jul 4, 2024
| @@ -52,6 +53,8 @@ export function MachineryTranslationComponent({ | |||
| if (llmTranslation) { | |||
| logUXAction('LLM Translation Copied', 'LLM Feature Adoption', { | |||
| action: 'Copy LLM Translation', | |||
| localeCode: locale.code, | |||
| targetLanguage: locale.name, | |||
There was a problem hiding this comment.
I wouldn't include targetLanguage, because localeCode is already unambiguous. It's also better to keep both related UX actions that are logged consistent in that regard.
No, that's enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3269
Updated user action logging by adding locale name and locale code when an LLM translation is copied. Additionally, updated the logging for dropdown selections to record the locale code instead of the locale name for the selected option.