Nebula 6 #19
Merged
Nebula 6 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # TODO: authentication using a path parameter | ||
|
|
||
| video_path = f"/mnt/nebula_01/.nx/proxy/{int(id_asset/1000):04d}/{id_asset}.mp4" | ||
| if not os.path.exists(video_path): |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| def range_requests_response(request: Request, file_path: str, content_type: str): | ||
| """Returns StreamingResponse using Range Requests of a given file""" | ||
|
|
||
| file_size = os.stat(file_path).st_size |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| status_code = status.HTTP_206_PARTIAL_CONTENT | ||
|
|
||
| return StreamingResponse( | ||
| send_bytes_range_requests(open(file_path, mode="rb"), start, end), |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
|
|
||
| def hash_password(password: str): | ||
| if config.password_hashing == "legacy": | ||
| return hashlib.sha256(password.encode("ascii")).hexdigest() |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic hashing algorithm on sensitive data
martastain
added a commit
that referenced
this pull request
Feb 13, 2023
Merge pull request #19 from nebulabroadcast/develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nebula 6 is a major release which breaks compatibility with the old API and settings (DB structure as well as the rest of the data remain the same tho, so it is possible to just update settings and upgrade).
nebulabroadcast/nebula becomes a monorepo of nebula-server, which is the API part of the system. Along with the API, it provides React-based web interface for the MAM part.