events: add stop propagation flag to Event.stopImmediatePropagation #39463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemadest
force-pushed
the
stop-immediate-propagation-flags
branch
from
33c4ebc
to
23744d2
Compare
mikemadest
changed the title
|
I didn't want to make a description too long, but feel like a bit more context could be interesting: When Event and EventTarget are available in Node js, the choice was to extend them to provide what was needed (bubbling in dispatchEvent). But since Event had everything needed I didn't think it would be required there, except for that tiny missing line in |
jasnell
approved these changes
Jul 20, 2021
|
Should this be closed? |
|
No this fix looks correct it was just missed - apologies this is our bad. |
benjamingr
approved these changes
Jun 26, 2023
github-actions
bot
removed
the
request-ci
No worries, thank you for the answer! |
mikemadest
force-pushed
the
stop-immediate-propagation-flags
branch
from
527ff4d
to
53f073d
Compare
|
Pull request updated: |
|
Thank you for your patience we truly don't deserve it and apologies for the contribution experience. Let's run CI and land this as soon as it's green. |
github-actions
bot
removed
the
request-ci
This was referenced Jun 28, 2023
mikemadest
force-pushed
the
stop-immediate-propagation-flags
branch
from
53f073d
to
d7de14d
Compare
This was referenced Jul 3, 2023
github-actions
bot
removed
the
request-ci
mikemadest
force-pushed
the
stop-immediate-propagation-flags
branch
from
c4739fa
to
d2b2e2c
Compare
benjamingr
approved these changes
Aug 9, 2023
github-actions
bot
removed
the
request-ci
mikemadest
force-pushed
the
stop-immediate-propagation-flags
branch
from
d2b2e2c
to
d712a39
Compare
github-actions
bot
removed
the
request-ci
benjamingr
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/39463 ✔ Done loading data for nodejs/node/pull/39463 ----------------------------------- PR info ------------------------------------ Title events: add stop propagation flag to Event.stopImmediatePropagation (#39463) Author Mickael Meausoone (@mikemadest, first-time contributor) Branch mikemadest:stop-immediate-propagation-flags -> nodejs:main Labels needs-ci Commits 1 - events: add stop propagation flag to Event.stopImmediatePropagation Committers 1 - Mickael Meausoone PR-URL: https://github.com/nodejs/node/pull/39463 Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39463 Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - events: add stop propagation flag to Event.stopImmediatePropagation ℹ This PR was created on Tue, 20 Jul 2021 08:02:57 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39463#pullrequestreview-710658397 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/39463#pullrequestreview-1569362103 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-08-14T09:35:27Z: https://ci.nodejs.org/job/node-test-pull-request/53301/ - Querying data for job/node-test-pull-request/53301/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5859369572 |
Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation
aduh95
force-pushed
the
stop-immediate-propagation-flags
branch
from
d712a39
to
991ae2e
Compare
aduh95
added
author ready
|
Landed in 04cf8c2 |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node.js as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation PR-URL: #39463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node.js as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation PR-URL: #39463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node.js as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation PR-URL: #39463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node.js as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation PR-URL: #39463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sophonieb
pushed a commit
to sophonieb/node
that referenced
this pull request
Jun 20, 2024
Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node.js as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation PR-URL: nodejs#39463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node.js as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation PR-URL: nodejs#39463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec mention stopImmediatePropagation should set both flags:
"stop propagation" and "stop immediate propagation".
So the second is not supported by Node as there is no hierarchy and bubbling,
but the flags are both present as well as stopPropagation.
Would it make sense to follow specs on that?
Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation