Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 11.8 #49639

Closed
wants to merge 29 commits into from
Closed

deps: update V8 to 11.8 #49639

wants to merge 29 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 13, 2023 •
edited
Loading

@targos targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 13, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 13, 2023 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/53930/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5562/
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5562/
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5562/
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5562/
@targos
Copy link
Member Author

targos commented Sep 13, 2023

I cherry-picked the fix for compilation on macOS
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Open
15 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53945/
@debadree25
Copy link
Member

The coverage windows job says There is not enough space on the disk. : 'D:\a\_temp\_runner_file_commands\add_path_f4e6d426-3628-4fdb-9b84-b7dc372c0b77' is this a github issue?
@github-actions github-actions bot mentioned this pull request Sep 15, 2023
Open
13 tasks
@targos
Copy link
Member Author

targos commented Sep 15, 2023

It's becoming critical that someone finds a fix for the zlib error. It happens in two of the builds:

https://ci.nodejs.org/job/node-test-commit-linux-containered/39302/nodes=ubuntu1804_sharedlibs_shared_x64/console

07:43:16 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_zlib/deps/v8/third_party/zlib/cpu_features.o:(.bss.x86_cpu_enable_avx512+0x0): multiple definition of `x86_cpu_enable_avx512'
07:43:16 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/zlib/deps/zlib/cpu_features.o:(.bss+0x0): first defined here

https://ci.nodejs.org/job/node-test-commit-smartos/51054/nodes=smartos20-64/console

07:51:39 ld: fatal: symbol 'x86_cpu_enable_avx512' is multiply-defined:
07:51:39 	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/zlib/libzlib.a(cpu_features.o) type=OBJT; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a(cpu_features.o) type=OBJT);
07:51:39 ld: fatal: symbol 'x86_cpu_enable_avx512' is multiply-defined:
07:51:39 	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/zlib/libzlib.a(cpu_features.o) type=OBJT; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a(cpu_features.o) type=OBJT);
07:51:39 ld: fatal: file processing errors. No output written to /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/embedtest

@nodejs/cpp-reviewers @nodejs/tsc
@targos
Copy link
Member Author

targos commented Sep 15, 2023

@nodejs/platform-aix PTAL at this:

https://ci.nodejs.org/job/node-test-commit-aix/48012/nodes=aix72-ppc64/console

07:58:44 ../deps/v8/src/heap/factory.cc: In member function 'v8::internal::Handle<v8::internal::WasmContinuationObject> v8::internal::Factory::NewWasmContinuationObject(v8::internal::Address, v8::internal::Handle<v8::internal::Foreign>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::AllocationType)':
07:58:44 ../deps/v8/src/heap/factory.cc:1921:11: error: 'class v8::internal::WasmContinuationObject' has no member named 'init_jmpbuf'; did you mean 'init___jmpbuf'?
07:58:44  1921 |   result->init_jmpbuf(isolate(), jmpbuf);
07:58:44       |           ^~~~~~~~~~~
07:58:44       |           init___jmpbuf
07:58:44 gmake[2]: *** [tools/v8_gypfiles/v8_base_without_compiler.target.mk:1102: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/heap/factory.o] Error 1
@RaisinTen
Copy link
Contributor

RaisinTen commented Sep 15, 2023 •
edited
Loading

@targos for the first one, does adding static next to the variables in https://github.com/targos/node/blob/763cfa9333be821123cb1b24ef65a02a981604b8/deps/zlib/cpu_features.c#L25-L34 and https://github.com/targos/node/blob/763cfa9333be821123cb1b24ef65a02a981604b8/deps/v8/third_party/zlib/cpu_features.c#L25-L34 like this:

before:

int ZLIB_INTERNAL x86_cpu_enable_avx512 = 0;

after:

static int ZLIB_INTERNAL x86_cpu_enable_avx512 = 0;

fix the issue?
@targos
Copy link
Member Author

targos commented Sep 15, 2023

It seems that a recent push to main breaks this PR. @joyeecheung maybe #48510 ?

/home/runner/work/node/node/out/Release/.deps//home/runner/work/node/node/out/Release/obj.target/libnode/src/node.o.d.raw   -c
In file included from ../deps/v8/include/v8-profiler.h:15,
                 from ../src/memory_tracker.h:5,
                 from ../src/base_object.h:29,
                 from ../src/module_wrap.h:9,
                 from ../src/module_wrap.cc:1:
../deps/v8/include/v8-local-handle.h: In instantiation of ‘v8::Local<T>::Local(v8::Local<S>) [with S = v8::Module; T = v8::Value]’:
../src/module_wrap.cc:61:27:   required from here
../deps/v8/include/v8-local-handle.h:253:42: error: static assertion failed: type check
  253 |     static_assert(std::is_base_of<T, S>::value, "type check");
      |                                          ^~~~~
../deps/v8/include/v8-local-handle.h:253:42: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
make[2]: *** [libnode.target.mk:492: /home/runner/work/node/node/out/Release/obj.target/libnode/src/module_wrap.o] Error 1
make[2]: *** Waiting for unfinished jobs....
rm 9ac559b3661ef3e3ae7143f36ccc6691e578b31c.intermediate 2ad06b2c9baade6b27c5c82cdcc7af11c369378d.intermediate
@joyeecheung
Copy link
Member

@targos You need both #49491 and #49419 for that to work. I suspect they are not yet in 11.8.
@targos
Copy link
Member Author

targos commented Sep 15, 2023

@RaisinTen static breaks it for me:

[16/3966] CC obj/deps/v8/third_party/zlib/v8_zlib.cpu_features.o
FAILED: obj/deps/v8/third_party/zlib/v8_zlib.cpu_features.o
cc -MMD -MF obj/deps/v8/third_party/zlib/v8_zlib.cpu_features.o.d -D_GLIBCXX_USE_CXX11_ABI=1 -DNODE_OPENSSL_CONF_NAME=nodejs_conf -DNODE_OPENSSL_HAS_QUIC -DICU_NO_USER_DATA_OVERRIDE -DV8_GYP_BUILD -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -D_DARWIN_USE_64_BIT_INODE=1 -DOPENSSL_NO_PINSHARED -DOPENSSL_THREADS -DV8_TARGET_ARCH_ARM64 -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_MACOS '-DV8_EMBEDDER_STRING="-node.7"' -DENABLE_DISASSEMBLER -DV8_PROMISE_INTERNAL_FIELD_COUNT=1 -DOBJECT_PRINT -DV8_INTL_SUPPORT -DV8_ATOMIC_OBJECT_FIELD_WRITES -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_USE_SIPHASH -DV8_SHARED_RO_HEAP -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_USE_ZLIB -DV8_ENABLE_TURBOFAN -DV8_ENABLE_SYSTEM_INSTRUMENTATION -DV8_ENABLE_WEBASSEMBLY -DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS -DV8_ALLOCATION_FOLDING -DV8_ALLOCATION_SITE_TRACKING -DV8_SCRIPTORMODULE_LEGACY_LIFETIME -DV8_ADVANCED_BIGINT_ALGORITHMS -DZLIB_IMPLEMENTATION -I../../deps/v8 -I../../deps/v8/include -I../../deps/v8/third_party/zlib -I../../deps/v8/third_party/zlib/google -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=11.0 -arch arm64 -Wall -Wendif-labels -W -Wno-unused-parameter -Wno-invalid-offsetof -fno-strict-aliasing  -c ../../deps/v8/third_party/zlib/cpu_features.c -o obj/deps/v8/third_party/zlib/v8_zlib.cpu_features.o
../../deps/v8/third_party/zlib/cpu_features.c:28:26: error: static declaration of 'Cr_z_arm_cpu_enable_crc32' follows non-static declaration
static int ZLIB_INTERNAL arm_cpu_enable_crc32 = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:193:30: note: expanded from macro 'arm_cpu_enable_crc32'
#define arm_cpu_enable_crc32 Cr_z_arm_cpu_enable_crc32
                             ^
../../deps/v8/third_party/zlib/cpu_features.h:12:12: note: previous declaration is here
extern int arm_cpu_enable_crc32;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:193:30: note: expanded from macro 'arm_cpu_enable_crc32'
#define arm_cpu_enable_crc32 Cr_z_arm_cpu_enable_crc32
                             ^
../../deps/v8/third_party/zlib/cpu_features.c:29:26: error: static declaration of 'Cr_z_arm_cpu_enable_pmull' follows non-static declaration
static int ZLIB_INTERNAL arm_cpu_enable_pmull = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:194:30: note: expanded from macro 'arm_cpu_enable_pmull'
#define arm_cpu_enable_pmull Cr_z_arm_cpu_enable_pmull
                             ^
../../deps/v8/third_party/zlib/cpu_features.h:13:12: note: previous declaration is here
extern int arm_cpu_enable_pmull;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:194:30: note: expanded from macro 'arm_cpu_enable_pmull'
#define arm_cpu_enable_pmull Cr_z_arm_cpu_enable_pmull
                             ^
../../deps/v8/third_party/zlib/cpu_features.c:31:26: error: static declaration of 'Cr_z_x86_cpu_enable_sse2' follows non-static declaration
static int ZLIB_INTERNAL x86_cpu_enable_sse2 = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:201:29: note: expanded from macro 'x86_cpu_enable_sse2'
#define x86_cpu_enable_sse2 Cr_z_x86_cpu_enable_sse2
                            ^
../../deps/v8/third_party/zlib/cpu_features.h:14:12: note: previous declaration is here
extern int x86_cpu_enable_sse2;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:201:29: note: expanded from macro 'x86_cpu_enable_sse2'
#define x86_cpu_enable_sse2 Cr_z_x86_cpu_enable_sse2
                            ^
../../deps/v8/third_party/zlib/cpu_features.c:32:26: error: static declaration of 'Cr_z_x86_cpu_enable_ssse3' follows non-static declaration
static int ZLIB_INTERNAL x86_cpu_enable_ssse3 = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:184:30: note: expanded from macro 'x86_cpu_enable_ssse3'
#define x86_cpu_enable_ssse3 Cr_z_x86_cpu_enable_ssse3
                             ^
../../deps/v8/third_party/zlib/cpu_features.h:15:12: note: previous declaration is here
extern int x86_cpu_enable_ssse3;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:184:30: note: expanded from macro 'x86_cpu_enable_ssse3'
#define x86_cpu_enable_ssse3 Cr_z_x86_cpu_enable_ssse3
                             ^
../../deps/v8/third_party/zlib/cpu_features.c:33:26: error: static declaration of 'Cr_z_x86_cpu_enable_simd' follows non-static declaration
static int ZLIB_INTERNAL x86_cpu_enable_simd = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:180:29: note: expanded from macro 'x86_cpu_enable_simd'
#define x86_cpu_enable_simd Cr_z_x86_cpu_enable_simd
                            ^
../../deps/v8/third_party/zlib/cpu_features.h:16:12: note: previous declaration is here
extern int x86_cpu_enable_simd;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:180:29: note: expanded from macro 'x86_cpu_enable_simd'
#define x86_cpu_enable_simd Cr_z_x86_cpu_enable_simd
                            ^
../../deps/v8/third_party/zlib/cpu_features.c:34:26: error: static declaration of 'x86_cpu_enable_avx512' follows non-static declaration
static int ZLIB_INTERNAL x86_cpu_enable_avx512 = 0;
                         ^
../../deps/v8/third_party/zlib/cpu_features.h:17:12: note: previous declaration is here
extern int x86_cpu_enable_avx512;
           ^
6 errors generated.
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53965/
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5566/
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5566/
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5566/
@joyeecheung
Copy link
Member

I am not familiar with the zlib update process (I think there used to be a doc, but I cannot find it any more), but I see that x86_cpu_enable_avx512 is added from https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/zlib/patches/0011-avx512.patch which does not get renamed like other similar flags in chromeconf.h.
@richardlau richardlau mentioned this pull request Sep 15, 2023
Merged
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 4, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
421f4ed 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 4, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
f5dadf4 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 5, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
848799a 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 5, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
f4f7401 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 6, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
7b876ae 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 6, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
256146c 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 7, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
6c4064a 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 7, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
297de95 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 8, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
7379e6c 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 8, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
e068099 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 9, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
8dacb0f 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 9, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
ea8f41a 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 10, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
7b13b7f 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 10, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
7e3a554 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 11, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
b7cfa3f 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 11, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
513f09f 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 12, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
f29c84d 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 12, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
3200e27 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 13, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
5602932 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 13, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
885aa43 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 14, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
a3b61ca 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 14, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
5e67b54 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 15, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
eed596e 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 15, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
069e377 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 16, 2024
@targos @nodejs-github-bot
deps: avoid compilation error with ASan
8613b8c 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 16, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
09fef38 
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit to targos/node that referenced this pull request Jul 17, 2024
@targos
deps: avoid compilation error with ASan
ae2de9a 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit to targos/node that referenced this pull request Jul 17, 2024
@targos
deps: patch V8 to avoid duplicated zlib symbol
ca19973 
PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit to targos/node that referenced this pull request Jul 17, 2024
@targos
deps: avoid compilation error with ASan
4092105 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit to targos/node that referenced this pull request Jul 17, 2024
@targos
deps: patch V8 to avoid duplicated zlib symbol
5ec28ae 
PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.