console: colorize console error and warn

[MrJithil]

Related to : 40361

Colorise string type args of console.error and console.warn. We are skipping the non-string types.

Tasks:

• Run CITGM

[MrJithil]

Will add test cases if this feature is acceptable

[MrJithil]

@MoLow I have changed the value of clear from '\u001bc' to '\u001b[0m'. Please check.

[ruyadorno]

I believe it's important to run through citgm to gauge the impact of this change.

[marco-ippolito]

I once again believe this should be marked as semver major change: #51503

[MrJithil]

I thought a bit more about this after talking with a few other folks and changed my mind on the remaining objection. LGTM 👍

thank you. proceeding further.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58746/

[MrJithil]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3422

Could you please help me to run this CIGTM? I haven't run this before and felt a little confusing. Since these tests are time consuming, thought to take help or opinion before retrying it.

[aduh95]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3422

Could you please help me to run this CIGTM? I haven't run this before and felt a little confusing. Since these tests are time consuming, thought to take help or opinion before retrying it.

$ ncu-ci.js citgm 3421 3422

FAILURE: 6 failures in 3422 not present in 3421


┌────────────────────────┬──────────────────┬───────────────────────┐
│        (index)         │        0         │           1           │
├────────────────────────┼──────────────────┼────────────────────���──┤
│       osx11-x64        │                  │                       │
│      rhel8-s390x       │                  │                       │
│       win-vs2022       │                  │                       │
│ alpine-last-latest-x64 │                  │                       │
│       rhel8-x64        │ 'undici-v6.14.1' │                       │
│      debian12-x64      │                  │                       │
│      debian11-x64      │  'jest-v0.0.0'   │    'semver-v7.6.0'    │
│   fedora-latest-x64    │                  │                       │
│     rhel8-ppc64le      │  'pino-v8.19.0'  │ 'prom-client-v15.1.2' │
│      aix72-ppc64       │                  │                       │
│     ubuntu2204-64      │ 'undici-v6.14.1' │                       │
│   alpine-latest-x64    │                  │                       │
│ fedora-last-latest-x64 │                  │                       │
└────────────────────────┴──────────────────┴───────────────────────┘

Now it's a matter of investigating whether those failures were caused by this PR or something else. For semver and prom-client, that's easy, No space left of device, so unrelated. For the other ones, it would require more careful review – but it seems fair to say landing this PR would not cause to much trouble to the ecosystem.

[MrJithil]

Landed in a833c9e

[Julian24Design]

Updated node to latest version, but console.error still outputs unclolored text. Is there any configuration required to achieve this?

[Jason3S]

I'm a bit surprised that this landed without a link to the discussion. #40361 is a feature request, but doesn't have a real discussion around the pros/cons and how it will impact the nodejs ecosystem.

I would have rather seen color added to the formatting of Errors instead of blanket red/yellow for console.error/console.warn.

I realize that in some way, this PR makes the behavior closer to that in the browser, but browsers do not have CLI applications.

I treat console.log and console.error as separate channels. Traditionally stdout is used for output of the program. It contains the result to be used, think grep. stderr is used for diagnostics, status, and messages to the user while the application is running. Color is not implied.

I would rather that this PR implemented color as a opt in vs trying to figure out how to opt out.