doc: add test_runner to subsystem #52774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
Fast-track has been requested by @rluvaton. Please 👍 to approve. |
rluvaton
added
the
test_runner
MoLow
approved these changes
May 1, 2024
lpinca
approved these changes
May 1, 2024
anonrig
approved these changes
May 1, 2024
rluvaton
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52774 ✔ Done loading data for nodejs/node/pull/52774 ----------------------------------- PR info ------------------------------------ Title doc: add test_runner to subsystem (#52774) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rluvaton:add-test-runner-to-subsystem -> nodejs:main Labels doc, fast-track, test_runner Commits 1 - doc: add test_runner to subsystem Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/52774 Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52774 Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 01 May 2024 12:00:06 GMT ✔ Approvals: 3 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52774#pullrequestreview-2033520194 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52774#pullrequestreview-2033531055 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52774#pullrequestreview-2033549041 ℹ This PR is being fast-tracked ✘ This PR needs to wait 46 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8910088175 |
marco-ippolito
approved these changes
May 1, 2024
rluvaton
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 956521c |
Ch3nYuY
pushed a commit
to Ch3nYuY/node
that referenced
this pull request
May 8, 2024
PR-URL: nodejs#52774 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 8, 2024
PR-URL: #52774 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52774 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
sophonieb
pushed a commit
to sophonieb/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52774 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52774 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.