tools: add --certify-safe to ncu-ci #52940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
Review requested:
|
mcollina
added
the
tsc-agenda
benjamingr
approved these changes
May 11, 2024
jasnell
approved these changes
May 11, 2024
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
|
nodejs/node-core-utils#806 would be a fix, this is more of a workaround. I still need help for writing tests BTW |
MoLow
approved these changes
May 11, 2024
lpinca
approved these changes
May 11, 2024
mcollina
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0fa07d4 |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #52940 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #52940 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #52940 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #52940 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sophonieb
pushed a commit
to sophonieb/node
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#52940 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#52940 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nodejs/node-core-utils#801