test: use python3 instead of python in pummel test #53057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
May 19, 2024
|
Change |
As f9bfe78 already did for a regular test, replace `python` with `python3` in the only `pummel` test spawning it so that it can be run on platforms that don't provide a `python` binary anymore, like modern macOS or some Linux distributions (e.g. Fedora) without specifying a `PYTHON` env var.
fahrradflucht
force-pushed
the
test-switch-to-python3-in-pummel
branch
from
c9b6fb5
to
b395a10
Compare
This comment was marked as resolved.
This comment was marked as resolved.
anonrig
approved these changes
May 31, 2024
anonrig
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jul 4, 2024
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 85f56ae |
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
As f9bfe78 already did for a regular test, replace `python` with `python3` in the only `pummel` test spawning it so that it can be run on platforms that don't provide a `python` binary anymore, like modern macOS or some Linux distributions (e.g. Fedora) without specifying a `PYTHON` env var. PR-URL: #53057 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
As f9bfe78 already did for a regular test, replace `python` with `python3` in the only `pummel` test spawning it so that it can be run on platforms that don't provide a `python` binary anymore, like modern macOS or some Linux distributions (e.g. Fedora) without specifying a `PYTHON` env var. PR-URL: #53057 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small test change I found myself floating on main:
As f9bfe78 already did for a regular test, replace
pythonwithpython3in the onlypummeltest spawning it so that it can be run on platforms that don't provide apythonbinary anymore, like modern macOS or some Linux distributions (e.g. Fedora) without specifying aPYTHONenv var.