Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v22.4.0 release proposal #53583

Merged
merged 102 commits into from
Jul 2, 2024
Merged

v22.4.0 release proposal #53583

merged 102 commits into from
Jul 2, 2024

Conversation

targos
Copy link
Member

@targos targos commented Jun 25, 2024

2024-07-02, Version 22.4.0 (Current), @targos

Notable Changes

Experimental Web Storage API

  • [9e30724b53] - (SEMVER-MINOR) deps,lib,src: add experimental web storage (Colin Ihrig) #52435

API stability updates

Other Notable Changes

  • [df4762722c] - doc: doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
  • [ad5282e196] - inspector: fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
  • [e95af740fc] - (SEMVER-MINOR) lib: add diagnostics_channel events to module loading (RafaelGSS) #44340
  • [50733a1abe] - (SEMVER-MINOR) util: support --no- for argument with boolean type for parseArgs (Zhenwei Jin) #53107

Commits

  • [9f32002397] - assert,util: correct comparison when both contain same reference (Daniel Lemire) #53431
  • [dfdc062111] - buffer: make indexOf(byte) faster (Tobias Nießen) #53455
  • [1de437527e] - build: configure with shared sqlite3 (Chengzhong Wu) #53519
  • [c7d44ba1f3] - build: find version of Clang installed on Windows (Stefan Stojanovic) #53228
  • [36aad8b204] - build: fix spacing before NINJA_ARGS (jakecastelli) #53181
  • [82092cdaa3] - crypto: improve GetECGroupBits signature (Tobias Nießen) #53364
  • [073c231607] - deps: update c-ares to v1.31.0 (Node.js GitHub Bot) #53554
  • [977beab729] - (SEMVER-MINOR) deps: sqlite: fix Windows compilation (Colin Ihrig) #52435
  • [e69b8d202c] - deps: update undici to 6.19.2 (Node.js GitHub Bot) #53468
  • [c4a7e051c8] - deps: update undici to 6.19.1 (Node.js GitHub Bot) #53468
  • [fa34f8fcf0] - deps: update undici to 6.19.1 (Node.js GitHub Bot) #53468
  • [0b40bfad43] - deps: update undici to 6.19.0 (Node.js GitHub Bot) #53468
  • [1877f22a79] - deps: update simdjson to 3.9.4 (Node.js GitHub Bot) #53467
  • [1b84964b8d] - deps: patch V8 to 12.4.254.21 (Node.js GitHub Bot) #53470
  • [6acadeb59b] - deps: update acorn-walk to 8.3.3 (Node.js GitHub Bot) #53466
  • [7a7f438841] - deps: update zlib to 1.3.0.1-motley-209717d (Node.js GitHub Bot) #53156
  • [bf891bf64c] - deps: update c-ares to v1.30.0 (Node.js GitHub Bot) #53416
  • [bd68888261] - deps: V8: cherry-pick a3cc8522a4c8 (kxxt) #53412
  • [2defaaf771] - deps: V8: cherry-pick 6ea594ff7132 (kxxt) #53412
  • [9e30724b53] - (SEMVER-MINOR) deps,lib,src: add experimental web storage (Colin Ihrig) #52435
  • [608cc05de1] - doc: recommend not using libuv node-api function (Michael Dawson) #53521
  • [30858eca59] - doc: add additional guidance for PRs to deps (Michael Dawson) #53499
  • [a5852cc710] - doc: only apply content-visibility on all.html (Filip Skokan) #53510
  • [befabe5c58] - doc: update the description of the return type for options.filter (Zhenwei Jin) #52742
  • [5ed1a036ba] - doc: remove first timer badge (Aviv Keller) #53338
  • [201266706b] - doc: move node --run stability to rc (Yagiz Nizipli) #53433
  • [46a7681cc4] - doc: add Buffer.from(string) to functions that use buffer pool (Christian Bates-White) #52801
  • [ec5364f6de] - doc: add initial text for ambassadors program (Michael Dawson) #52857
  • [fa113b8fc7] - doc: fix typo (EhsanKhaki) #53397
  • [d9182d0086] - doc: define more cases for stream event emissions (Aviv Keller) #53317
  • [923d24b6f2] - doc: remove mentions of policy model from security info (Aviv Keller) #53249
  • [48f78cd31b] - doc: fix mistakes in the module load hook api (István Donkó) #53349
  • [16c0884d48] - doc: mark WebSocket as stable (Matthew Aitken) #53352
  • [df4762722c] - doc: doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
  • [cf375e73c1] - doc: mark --heap-prof and related flags stable (Joyee Cheung) #53343
  • [0160745057] - doc: mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  • [6e12d9f049] - doc: remove IRC from man page (Tobias Nießen) #53344
  • [24c7a9415b] - doc, http: add rejectNonStandardBodyWrites option, clear its behaviour (jakecastelli) #53396
  • [ec38f3dc6a] - doc, meta: organize contributing to Node-API guide (Aviv Keller) #53243
  • [cf5a973c42] - doc, meta: use markdown rather than HTML in CONTRIBUTING.md (Aviv Keller) #53235
  • [105b006fd2] - fs: move ToNamespacedPath to c++ (Yagiz Nizipli) #52135
  • [568377f7f0] - fs: do not crash if the watched file is removed while setting up watch (Matteo Collina) #53452
  • [fad179307c] - fs: add fast api for InternalModuleStat (Yagiz Nizipli) #51344
  • [41100b65f6] - http2: reject failed http2.connect when used with promisify (ehsankhfr) #53475
  • [ad5282e196] - inspector: fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
  • [b5fc227344] - lib: fix typo in comment (codediverdev) #53543
  • [e95af740fc] - (SEMVER-MINOR) lib: add diagnostics_channel events to module loading (RafaelGSS) #44340
  • [123910f1de] - lib: remove the unused code (theanarkh) #53463
  • [452011b719] - lib: speed up MessageEvent creation internally (Matthew Aitken) #52951
  • [710cf7758c] - lib: reduce amount of caught URL errors (Yagiz Nizipli) #52658
  • [45b59e58d1] - lib: fix naming convention of Symbol (Deokjin Kim) #53387
  • [515dd24ee7] - lib: fix timer leak (theanarkh) #53337
  • [77166137be] - meta: use correct source for workflow in PR (Aviv Keller) #53490
  • [d1c10fee53] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #53480
  • [a5026386bf] - meta: fix typo in dependency updates (Aviv Keller) #53471
  • [0b9191da99] - meta: bump step-security/harden-runner from 2.7.1 to 2.8.0 (dependabot[bot]) #53245
  • [49cfb9d001] - src: reset process.versions during pre-execution (Richard Lau) #53444
  • [15df4edd22] - src: use args.This() instead of Holder (Michaël Zasso) #53474
  • [e16a04e852] - src: fix dynamically linked OpenSSL version (Richard Lau) #53456
  • [5961253824] - src: remove base64 from process.versions (Richard Lau) #53442
  • [11dd15c0b5] - src: remove SetEncoding from StringEncoder (Yagiz Nizipli) #53441
  • [0c7e69acd2] - src: simplify size() == 0 checks (Yagiz Nizipli) #53440
  • [f077afafda] - src: add utilities to help debugging reproducibility of snapshots (Joyee Cheung) #50983
  • [004b9ea4c4] - src: make sure that memcpy-ed structs in snapshot have no padding (Joyee Cheung) #50983
  • [bfc5236423] - src: return non-empty data in context data serializer (Joyee Cheung) #50983
  • [955454ba4d] - src: fix typo in env.cc (EhsanKhaki) #53418
  • [7d8787768c] - src: avoid strcmp in favor of operator== (Tobias Nießen) #53439
  • [599e7c3d8e] - src: remove ArrayBufferAllocator::Reallocate override (Shu-yu Guo) #52910
  • [f9075ff38e] - src: print v8::OOMDetails::detail when it's available (Joyee Cheung) #53360
  • [4704270443] - src: fix IsIPAddress for IPv6 (Hüseyin Açacak) #53400
  • [63f62d76de] - src: fix permission inspector crash (theanarkh) #53389
  • [70bbc02dac] - src, deps: add nbytes library (James M Snell) #53507
  • [8b877099d0] - stream: update outdated highwatermark doc (Jay Kim) #53494
  • [eded1e9768] - stream: support dispose in writable (Benjamin Gruenbaum) #48547
  • [b3372a8b0e] - stream: callback should be called when pendingcb is 0 (jakecastelli) #53438
  • [f4efb7f625] - stream: make sure _destroy is called (jakecastelli) #53213
  • [7dde37591c] - stream: prevent stream unexpected pause when highWaterMark set to 0 (jakecastelli) #53261
  • [6e66d9763f] - test: mark test-benchmark-crypto as flaky (Antoine du Hamel) #52955
  • [1eebcbf9bf] - test: skip reproducible snapshot test on 32-bit (Michaël Zasso) #53592
  • [91b2850303] - test: extend env for test-node-output-errors (Richard Lau) #53535
  • [bcad560726] - test: update compression web-platform tests (Yagiz Nizipli) #53478
  • [b8f436c755] - test: update encoding web-platform tests (Yagiz Nizipli) #53477
  • [d2c169a4f6] - test: update url web-platform tests (Yagiz Nizipli) #53472
  • [513e6aa4c7] - test: check against run-time OpenSSL version (Richard Lau) #53456
  • [602b9d63c4] - test: update tests for OpenSSL 3.0.14 (Richard Lau) #53373
  • [4a3525bb08] - test: fix test-http-server-keepalive-req-gc (Etienne Pierre-doray) #53292
  • [7349edb28b] - test: update TLS tests for OpenSSL 3.2 (Richard Lau) #53384
  • [a11a05763d] - tls: check result of SSL_CTX_set_*_proto_version (Tobias Nießen) #53459
  • [4b47f89eb2] - tls: avoid taking ownership of OpenSSL objects (Tobias Nießen) #53436
  • [ac8adeb99f] - tls: use SSL_get_peer_tmp_key (Tobias Nießen) #53366
  • [d5c380bb09] - tools: lock versions of irrelevant DB deps (Michaël Zasso) #53546
  • [71321bb249] - tools: fix skip detection of test runner output (Richard Lau) #53545
  • [ca198f4125] - tools: update eslint to 9.5.0 (Node.js GitHub Bot) #53515
  • [30fdd482a1] - tools: move ESLint to tools/eslint (Michaël Zasso) #53413
  • [fe85e05ba9] - tools: fix c-ares update script (Marco Ippolito) #53414
  • [8eb7bdf81b] - tools: update lint-md-dependencies (Node.js GitHub Bot) #53158
  • [9ece63d415] - tools: do not run Corepack code before it's reviewed (Antoine du Hamel) #53405
  • [ab2021492b] - tools: move ESLint tools to tools/eslint (Michaël Zasso) #53393
  • [78a9037a6d] - tools: use Ubuntu 24.04 and Clang on GitHub actions (Michaël Zasso) #53212
  • [855eb25dad] - tools: add stream label on PR when related files being changed in lib (jakecastelli) #53269
  • [50733a1abe] - (SEMVER-MINOR) util: support --no- for argument with boolean type for parseArgs (Zhenwei Jin) #53107
tniessen and others added 30 commits June 20, 2024 14:40
PR-URL: #53344
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #53337
Fixes: #53335
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
OpenSSL 3 deprecated support for custom engines with a recommendation
to switch to its new provider model.

PR-URL: #53329
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #53352
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #53269
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #53349
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #53249
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #53181
Fixes: #53176
Refs: #53176
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
PR-URL: #53261
Fixes: #51930
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #53317
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #53235
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.7.1 to 2.8.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@a4aa98b...f086349)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #53245
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Update the following TLS tests to account for error code changes
in OpenSSL 3.2 and later.
- `parallel/test-tls-empty-sni-context`
- `parallel/test-tls-psk-circuit`

PR-URL: #53384
Refs: #53382
Refs: openssl/openssl#19950
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
This puts us closer to what V8 actively supports.
GCC is still covered a lot by Jenkins CI.

Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #53212
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.

PR-URL: #53292
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #53213
Fixes: #51987
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: #53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Starting from OpenSSL 3.0.14, 3.1.6, 3.2.2, and 3.3.1, OpenSSL was fixed
to return an error reason string for bad/unknown application protocols.

Update tests to handle both the old `ECONNRESET` error on older versions
of OpenSSL and the new `ERR_SSL_TLSV1_ALERT_NO_APPLICATION_PROTOCOL` on
newer versions of OpenSSL.

Refs: openssl/openssl#24338
PR-URL: #53373
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #53389
Fixes: #53385
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Remove the unused ECPointer argument and rename the function since the
current name is misleading.

PR-URL: #53364
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #53397
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
With ESLint flat config, we don't need a hack with `node_modules`
anymore to load ESLint plugins.
This commit moves the node-core plugin out of `tools/node_modules` and
creates a new `tools/eslint` directory to store ESLint tools.

PR-URL: #53393
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #53396
Fixes: #53035
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #53228
Refs: #52809
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Also enable running `make corepack-update` when `node`/`npm` is not
available globally.

PR-URL: #53405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fix the bug when copying IPv6 host to a variable to remove brackets.

Fixes: #47427
PR-URL: #53400
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
This provides a bit more information when V8 runs out of memory.

PR-URL: #53360
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Original commit message:

    [riscv] Skip check sv57 when enable pointer compress

    Change-Id: I4332d3849d113af105630c0e20cd2b5e3deb9392
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5430889
    Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#93244}

Refs: v8/v8@6ea594f
PR-URL: #53412
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. dependencies Pull requests that update a dependency file. labels Jun 26, 2024
@targos
Copy link
Member Author

targos commented Jun 26, 2024

@ljharb I'm seeing not ok 245 test/mock_loader is a core module errors in resolve's tests. What does it mean?

@targos
Copy link
Member Author

targos commented Jun 26, 2024

@targos
Copy link
Member Author

targos commented Jun 26, 2024

It's taking too long (and has random connection failures with the downloads server). I probably won't have time to finish the release today.

aduh95 and others added 2 commits July 1, 2024 15:31
PR-URL: #52955
Refs: #52690
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
@targos

This comment was marked as duplicate.

1 similar comment
@targos
Copy link
Member Author

targos commented Jul 2, 2024

@targos targos merged commit 7e13cc5 into v22.x Jul 2, 2024
49 checks passed
@targos targos deleted the v22.4.0-proposal branch July 2, 2024 08:48
targos added a commit that referenced this pull request Jul 2, 2024
targos added a commit that referenced this pull request Jul 2, 2024
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
targos added a commit to targos/nodejs.org that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.