Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: document the Node.js context emebdder data #53611

Merged
merged 1 commit into from
Jul 6, 2024
Merged

src: document the Node.js context emebdder data #53611

merged 1 commit into from
Jul 6, 2024

Conversation

joyeecheung
Copy link
Member

Just noticed that they are never properly documented and I found myself explaining to others from the top of my head again. So might as well just add some comments to document them.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 27, 2024
@joyeecheung joyeecheung force-pushed the context-data-comment branch 2 times, most recently from df9ef76 to 02c7da8 Compare June 27, 2024 17:24
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59991/
legendecas
legendecas reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a nit
src/node_context_data.h Outdated Show resolved Hide resolved
@RedYetiDev
Copy link
Member

Commit message typo: emebdder -> embedder
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60100/
@joyeecheung
Copy link
Member Author

@VoltrexKeyva @addaleax @legendecas PTAL again, thanks!
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60103/
@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8825dc3 into nodejs:main Jul 6, 2024
54 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8825dc3
aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@joyeecheung @aduh95
src: document the Node.js context embedder data
be4ffaa 
PR-URL: #53611
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@joyeecheung @aduh95
src: document the Node.js context embedder data
94c7054 
PR-URL: #53611
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
6 participants
@joyeecheung @nodejs-github-bot @RedYetiDev @addaleax @legendecas @VoltrexKeyva