-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc, child_process: add esm snippets #53616
Open
RedYetiDev
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
RedYetiDev:patch-62
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atlowChemi
reviewed
Jun 28, 2024
Comment on lines
-129
to
-144
```js | ||
// OR... | ||
const { exec, spawn } = require('node:child_process'); | ||
exec('my.bat', (err, stdout, stderr) => { | ||
if (err) { | ||
console.error(err); | ||
return; | ||
} | ||
console.log(stdout); | ||
```mjs | ||
import { spawn } from 'node:child_process'; | ||
const spawned = spawn('my_command', ['arguments']); | ||
|
||
spawned.stdout.on('data', (data) => { | ||
console.log(data.toString()); | ||
}); | ||
|
||
// Script with spaces in the filename: | ||
const bat = spawn('"my script.cmd"', ['a', 'b'], { shell: true }); | ||
// or: | ||
exec('"my script.cmd" a b', (err, stdout, stderr) => { | ||
// ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were modified because in the original, because they are exclusive to Windows, and may confuse POSIX users
atlowChemi
reviewed
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
review wanted
PRs that need reviews.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ESM snippets to the documentation for
node:child_process
.In addition to this, some snippets were modified for readability (
message
instead ofm
, etc)