Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: test timeout NaN warning in promises version #53622

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

timers: test timeout NaN warning in promises version #53622

wants to merge 2 commits into from
+11 −0

Conversation

benjamingr
Copy link
Member

@benjamingr benjamingr commented Jun 28, 2024 •
edited
Loading

Hey, #46678 landed adding a warning when NaN is passed to timers. I noticed a test was missing for timers/promises there (the code works on both paths) - rather than holding that PR I figured we'd land it and I'd PR a test for timers/promises in a separate PR.

cc @jakecastelli
@benjamingr benjamingr added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 28, 2024
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 28, 2024
@debadree25 debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2024
@debadree25
Copy link
Member

debadree25 commented Jun 28, 2024 •
edited
Loading

weird the CI bot is not here yet 🤔

Edit: ah CI is in lockdown missed the PSA oops
@benjamingr @legendecas
Update test/parallel/test-timers-nan-duration-warning-promises.js
8074052 
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v21.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Jun 29, 2024
@aduh95
Copy link
Contributor

aduh95 commented Jun 29, 2024

The subsystem should be test: given it only touch the tests. Removed semver-major PRs that contain breaking changes and should be released in the next major version. in favor of dont-land labels.
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60042/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
8 participants
@benjamingr @debadree25 @aduh95 @nodejs-github-bot @jasnell @lpinca @legendecas @targos