Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: fix typings #53626

Merged
merged 2 commits into from
Jul 4, 2024
Merged

fs: fix typings #53626

merged 2 commits into from
Jul 4, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jun 28, 2024

Fix jsdoc and typescript types in lib/fs.js

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings labels Jun 28, 2024
lib/fs.js Outdated Show resolved Hide resolved
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does more than just fix typings, can you amend the commit message to reflect that? (or split the PR if the other changes were meant to be separated)

@anonrig
Copy link
Member Author

anonrig commented Jun 29, 2024

This does more than just fix typings, can you amend the commit message to reflect that? (or split the PR if the other changes were meant to be separated)

I spent 5+ minutes but couldn't find a good commit message. Any suggestions?

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 4, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/53626
✔  Done loading data for nodejs/node/pull/53626
----------------------------------- PR info ------------------------------------
Title      fs: fix typings (#53626)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:fs-fix-typings -> nodejs:main
Labels     fs, needs-ci, typings
Commits    2
 - fs: fix typings
 - Update lib/fs.js
Committers 2
 - Yagiz Nizipli 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/53626
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53626
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 28 Jun 2024 14:37:25 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/53626#pullrequestreview-2149611133
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53626#pullrequestreview-2157909752
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-07-04T01:28:41Z: https://ci.nodejs.org/job/node-test-pull-request/60053/
- Querying data for job/node-test-pull-request/60053/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 53626
From https://github.com/nodejs/node
 * branch                  refs/pull/53626/merge -> FETCH_HEAD
✔  Fetched commits as ce2faef3a70a..634bd62d0c03
--------------------------------------------------------------------------------
Auto-merging typings/internalBinding/fs.d.ts
[main c482d15044] fs: fix typings
 Author: Yagiz Nizipli 
 Date: Fri Jun 28 10:37:10 2024 -0400
 2 files changed, 20 insertions(+), 20 deletions(-)
[main 8e868d2d04] Update lib/fs.js
 Author: Yagiz Nizipli 
 Date: Fri Jun 28 10:52:24 2024 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fs: fix typings

PR-URL: #53626
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 6c463e6ae8] fs: fix typings
Author: Yagiz Nizipli yagiz@nizipli.com
Date: Fri Jun 28 10:37:10 2024 -0400
2 files changed, 20 insertions(+), 20 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update lib/fs.js

PR-URL: #53626
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD b36f1ec04a] Update lib/fs.js
Author: Yagiz Nizipli yagiz@nizipli.com
Date: Fri Jun 28 10:52:24 2024 -0400
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/9792871085

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit f1ac7df into nodejs:main Jul 4, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f1ac7df

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
PR-URL: #53626
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
PR-URL: #53626
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings
4 participants