Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: add setKeyCert() to tls.Socket #53636

Merged
merged 1 commit into from
Jul 15, 2024
Merged

tls: add setKeyCert() to tls.Socket #53636

merged 1 commit into from
Jul 15, 2024

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jun 29, 2024

This is mostly useful for implementing the ACME TLS-ALPN-01 challenge by overriding the certificate from a TLS server's ALPNCallback.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 29, 2024
@mscdex
Copy link
Contributor Author

mscdex commented Jul 7, 2024

Can this get labeled with author ready?
@pimterry pimterry added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60149/
@mscdex
Copy link
Contributor Author

mscdex commented Jul 13, 2024

As far as I can tell this should be ready to land.
@pimterry pimterry added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6ba0af1 into nodejs:main Jul 15, 2024
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6ba0af1
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@mscdex @aduh95
tls: add setKeyCert() to tls.Socket
a020f3f 
PR-URL: #53636
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@mscdex @aduh95
tls: add setKeyCert() to tls.Socket
4d777de 
PR-URL: #53636
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
5 participants
@mscdex @nodejs-github-bot @jasnell @pimterry @anonrig