Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: move watchers ToNamespacedPath calls to C++ #53657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fs: move watchers ToNamespacedPath calls to C++ #53657

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jun 30, 2024

Removes toNamespacedPath calls in fs/watchers.js and moves it to C++
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 30, 2024
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60030/
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60129/
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60173/
@anonrig anonrig force-pushed the watchers-tonamespaced-path branch from c8dcfad to e8a78d6 Compare July 15, 2024 00:03
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60319/
@anonrig anonrig force-pushed the watchers-tonamespaced-path branch from e8a78d6 to 104d0c0 Compare July 15, 2024 14:35
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60332/
@anonrig anonrig force-pushed the watchers-tonamespaced-path branch from 104d0c0 to a1f4c1f Compare July 15, 2024 16:13
@anonrig anonrig force-pushed the watchers-tonamespaced-path branch from a1f4c1f to a424e95 Compare July 15, 2024 16:14
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60365/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
4 participants
@anonrig @nodejs-github-bot @jasnell @MoLow