test: fix embedding test for Windows

[vmoroz]

PR #52905 had added a new test case for embedding test which was failing for Windows.
The reason was that the expected error message has the Posix-specific line ending \n while on Windows the output string contains \r\n:

stderr: `${binary}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv\n`,

PR #52905 temporary disabled this new test case for Windows.

This PR removes the temporary test disablement for Windows and implements the fix by replacing \r\n in the the output string with \n before comparison.
After this change the embedding test is passing for Windows.

[joyeecheung]

LGTM although I think it's fine to simply use a looser regexp in test-embedding.js and just match

stderr: /NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv/

[vmoroz]

LGTM although I think it's fine to simply use a looser regexp in test-embedding.js and just match

stderr: /NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv/

Thanks! I had considered it initially, but decided on the str.replaceAll solution mostly to avoid similar issues in future. Developers who do not have access to Windows machines can use the \n in any other tests and not to be blocked anymore.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60029/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60271/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60282/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60331/