Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add additional explanation to the wildcard section in permissions #53664

Conversation

jakecastelli
Copy link
Contributor

Refs: #53621 (comment), #53621 (comment)

Hopefully this makes the wildcard behaviours in permissions more clear.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 1, 2024
doc/api/permissions.md Outdated Show resolved Hide resolved
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@jakecastelli jakecastelli force-pushed the improve-fs-permission-doc-based-53621 branch from 7dfbdc3 to 00cfbf7 Compare July 1, 2024 13:34
@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 2, 2024
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7622dd8 into nodejs:main Jul 4, 2024
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7622dd8

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #53664
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #53664
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
5 participants