Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix mac build error of c-ares under GN #53687

Merged
merged 1 commit into from
Jul 5, 2024
Merged

build: fix mac build error of c-ares under GN #53687

merged 1 commit into from
Jul 5, 2024

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Jul 2, 2024

Match the changes in #53155.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2024
@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60022/
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60069/
@zcbenz zcbenz added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 60b2754 into nodejs:main Jul 5, 2024
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 60b2754
aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@zcbenz @aduh95
build: fix mac build error of c-ares under GN
0912737 
PR-URL: #53687
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@zcbenz @aduh95
build: fix mac build error of c-ares under GN
082799d 
PR-URL: #53687
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
5 participants
@zcbenz @nodejs-github-bot @jasnell @lpinca @anonrig