http2: remove prototype primordials #53696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http2
marco-ippolito
approved these changes
Jul 2, 2024
MoLow
approved these changes
Jul 2, 2024
benjamingr
approved these changes
Jul 2, 2024
anonrig
approved these changes
Jul 2, 2024
anonrig
approved these changes
Jul 2, 2024
aduh95
commented
Jul 2, 2024
anonrig
approved these changes
Jul 2, 2024
aduh95
added
author ready
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
force-pushed
the
http2-bye-bye-primordials
branch
from
ef4a21a
to
6e0c0f0
Compare
aduh95
added
the
commit-queue-squash
lpinca
approved these changes
Jul 2, 2024
aduh95
commented
Jul 2, 2024
atlowChemi
approved these changes
Jul 3, 2024
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jul 4, 2024
RafaelGSS
approved these changes
Jul 4, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 88beb76 |
aduh95
added a commit
that referenced
this pull request
Jul 12, 2024
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: #53696 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
aduh95
added a commit
that referenced
this pull request
Jul 16, 2024
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: #53696 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yagiz and I paired to remove primordials in http2 files, as those are really just a JS lib that happens to be in core, not something for which prototype pollution is a big concern.