Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: require node:process in assert doc examples #53702

Merged
merged 1 commit into from
Jul 4, 2024
Merged

doc: require node:process in assert doc examples #53702

merged 1 commit into from
Jul 4, 2024

Conversation

mfdebian
Copy link
Contributor

@mfdebian mfdebian commented Jul 2, 2024 •
edited
Loading

The CJS example of new assert.CallTracker() does not provide the corresponding require import for node:process, the other examples do include it.
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jul 2, 2024
@mfdebian mfdebian changed the title doc: added require for process to cjs example of assertCallTracker() Jul 2, 2024
@RedYetiDev
Copy link
Member

Thanks for the PR! Could you possible shorten the commit message?

Maybe doc: require `node:process` in assert doc examples
@mfdebian mfdebian changed the title doc: add require for process to cjs example of assertCallTracker() Jul 2, 2024
@mfdebian
Copy link
Contributor Author

mfdebian commented Jul 2, 2024

@RedYetiDev done! 😊
@RedYetiDev
Copy link
Member

Thanks! When the collaborators get a chance to see your PR, they'll provide a more in depth review.
@mfdebian
Copy link
Contributor Author

mfdebian commented Jul 2, 2024

Perfect! Any feedback is greatly appreciated, I'll be trying to contribute more! 🙏
@H4ad H4ad added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit ba3aedc into nodejs:main Jul 4, 2024
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ba3aedc
aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@mfdebian @aduh95
doc: require node:process in assert doc examples
0b0b0e8 
PR-URL: #53702
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@mfdebian @aduh95
doc: require node:process in assert doc examples
50987ea 
PR-URL: #53702
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
7 participants
@mfdebian @RedYetiDev @nodejs-github-bot @benjamingr @UlisesGascon @atlowChemi @H4ad