Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: unify experimental warning messages #53704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

process: unify experimental warning messages #53704

wants to merge 1 commit into from

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Jul 2, 2024 •
edited
Loading

Fixes #30803

This PR changes the warnings emitted by --experimental-permission and --frozen-intrinsics to use emitExperimentalWarning for their emissions, keeping the emitted warning uniform.

Old

old@nodejs:~$ node --frozen-intrinsics --experimental-permission -e ''
(node:434007) ExperimentalWarning: Permission is an experimental feature
(Use `node --trace-warnings ...` to show where the warning was created)
(node:434007) ExperimentalWarning: The --frozen-intrinsics flag is experimental

New

new@nodejs:~$ node --frozen-intrinsics --experimental-permission -e ''
(node:434330) ExperimentalWarning: Permission is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:434330) ExperimentalWarning: Frozen intristics is an experimental feature and might change at any time
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jul 2, 2024
@RedYetiDev RedYetiDev added the experimental Issues and PRs related to experimental features. label Jul 2, 2024
@RedYetiDev RedYetiDev force-pushed the uniform-experimental-warnings branch from 78157ae to 14119c4 Compare July 2, 2024 23:37
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60058/
@RedYetiDev
Copy link
Member Author

Is this good to commit-queue?
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60261/
@RedYetiDev
Copy link
Member Author

RedYetiDev commented Jul 12, 2024 •
edited
Loading

Failed CI is unrelated test_error_serdes
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60326/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
10 participants
@RedYetiDev @nodejs-github-bot @panva @jasnell @benjamingr @lpinca @anonrig @targos @marco-ippolito @atlowChemi