Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: add missing documentation for URL.parse() #53733

Merged
merged 3 commits into from
Jul 5, 2024
Merged

url: add missing documentation for URL.parse() #53733

merged 3 commits into from
Jul 5, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 4, 2024

Adds missing documentation for #52280. @nodejs/url
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Jul 4, 2024
@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Fast-track has been requested by @anonrig. Please 👍 to approve.
@anonrig anonrig requested review from mcollina and jasnell July 4, 2024 22:21
KhafraDev
KhafraDev reviewed Jul 5, 2024
View reviewed changes
doc/api/url.md Outdated Show resolved Hide resolved
@anonrig @KhafraDev
Update url.md
cc6cca8 
Co-authored-by: Khafra <maitken033380023@gmail.com>
@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 5, 2024
anonrig
anonrig commented Jul 5, 2024
View reviewed changes
doc/api/url.md Outdated Show resolved Hide resolved
@anonrig anonrig requested a review from KhafraDev July 5, 2024 01:09
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 5, 2024
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 5a775b3 into nodejs:main Jul 5, 2024
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5a775b3
@anonrig anonrig deleted the add-url-parse branch July 9, 2024 16:16
aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig @aduh95
url: add missing documentation for URL.parse()
ab89f0a 
PR-URL: #53733
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig @aduh95
url: add missing documentation for URL.parse()
1300169 
PR-URL: #53733
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.
4 participants
@anonrig @nodejs-github-bot @jasnell @KhafraDev