Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,tools: enable --trace-sigint in tests by default #53747

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src,tools: enable --trace-sigint in tests by default #53747

wants to merge 1 commit into from
+41 −32

Conversation

legendecas
Copy link
Member

Enable --trace-sigint in tests by default. Also fixes
an internal test test/parallel/test-util-sigint-watchdog.js
that crashes with --trace-sigint.

Refs: #53739
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jul 6, 2024
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 6, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
joyeecheung
joyeecheung approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is happy with it
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60142/
@joyeecheung
Copy link
Member

Can't really tell why from the logs, but the coverage builds were failing. Restarted to see if those are flakes.
@legendecas
Copy link
Member Author

I think they reproduce consistently. I am trying to setup a local coverage environment to verify it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
4 participants
@legendecas @nodejs-github-bot @joyeecheung @jasnell