deps: update ada to 2.9.0 #53748
Merged
deps: update ada to 2.9.0 #53748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
dependencies
|
Review requested:
|
marco-ippolito
approved these changes
Jul 7, 2024
|
@marco-ippolito the build is broken |
We were using a private function which got removed. The fix is simple one line change. |
anonrig
added
the
commit-queue-squash
anonrig
approved these changes
Jul 7, 2024
anonrig
added
request-ci
|
@nodejs/tsc can someone run a |
anonrig
added
the
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jul 7, 2024
benjamingr
approved these changes
Jul 7, 2024
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in bb7fc65 |
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53748 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of ada to 2.9.0.