Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: improve cluster/primary code #53756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: improve cluster/primary code #53756

wants to merge 1 commit into from
+3 −5

Conversation

ehsankhfr
Copy link
Contributor

Improved code for lib/cluster/primary:

  • Removed redundant Object.Keys
  • Removed redundant const
@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. labels Jul 7, 2024
RedYetiDev
RedYetiDev reviewed Jul 7, 2024
View reviewed changes
lib/internal/cluster/primary.js

if (workers.length === 0) {
process.nextTick(() => intercom.emit('disconnect'));
} else {
for (const worker of ObjectValues(cluster.workers)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration applicable here?
@RedYetiDev
Copy link
Member

@nodejs/cluster
benjamingr
benjamingr approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it may make sense to also address the for of primordials issue but that code was for..of before so that isn't a regression
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60148/
mcollina
mcollina approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run.
7 participants
@ehsankhfr @RedYetiDev @nodejs-github-bot @mcollina @benjamingr @anonrig @trivikr