Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix most issues: npm8 support, github actions, npx shim #258

Merged
merged 13 commits into from
Nov 19, 2023
Merged

Fix most issues: npm8 support, github actions, npx shim #258

merged 13 commits into from
Nov 19, 2023

Conversation

Mairu
Copy link
Contributor

@Mairu Mairu commented Aug 22, 2022

This PR / branch also includes the open PR #240 and #246.

  • uses newer go version for building shims
  • allows usage of npm8 by fixing the symlinks used by npm8
  • uses EnVar plugin for MSIS installer
  • add github actions to run tests and build the installer with a draft release for new tags
ashidaharo and others added 12 commits September 21, 2021 13:42
@ashidaharo
Revert "fix(npm ls): resolve to correct version"
ce42d15 
This reverts commit 710c27c.
@ashidaharo
fix Handling latest in npm
947299e
@fealebenpae
Use the Octokit client for GitHub
f4c997b 
This replaces the old `github` package with the latest Octokit REST client which makes authentication work again.
Additionally, the `NODIST_GITHUB_TOKEN` environment variable can now be used to supply a token for authenticating GitHub requests (and overcoming the unauthenticated request rate limit).
@Mairu
Merge branch 'featire/fix_npm_latest' into main
bf6fbb8
@Mairu
fix(building shims): use go modules and an existing fork of go-debug
2ebed89
@Mairu
fix(build): use last x86 node version, fix last npm version and usage…
e29fcd9 
… of symlinks
@Mairu
fix(tests): fix tests and add check for node and cleanup before run
82ab4b6
@Mairu
fix(chore): update dependencies, changelog, usage and build templates
339ea53
@Mairu
feat(npm8): support npm 8 by fixing symlinks during installation
8c9fa1c
@Mairu
build(nsis): use EnVar plugin for path env variable updates
d7122b0
@Mairu
feat(npx): add shim for npx
f8db08d
@Mairu
feat(ci): add GitHub action workflows for tests and release
55ea5d6 
- download used NSIS plugins before build and use them from that local folder
- raise minimum node version (needed for building and using nodist) to 12
@antonkallenberg
Copy link

@Mairu Do you have an installer? Tried to build one from your fork but got errors.

image
@Mairu
Copy link
Contributor Author

Mairu commented Oct 12, 2022

Hi, it seems the npm version cannot be fetched since something has changed in the meantime. I can perhaps take a look at the weekend and will build a version in my forked repo.
@antonkallenberg
Copy link

@Mairu No stress, I just returned the latest npm version from that function (without making the http request.) Then the build completed without errors. Thank you for the fork :)
@Mairu
Copy link
Contributor Author

Mairu commented Oct 15, 2022

I fixed the issue, so the build works again. Also created a pre-release in my repo if anybody is interested in using it -> https://github.com/Mairu/nodist/releases/tag/v0.10.0-beta.2
@nullivex
Copy link
Member

Thank you for the work. I will review this and work on an official build.
@gene-pavlovsky
Copy link

gene-pavlovsky commented Nov 4, 2023 •
edited
Loading

Any news @nullivex @Mairu ?
@Mairu
Copy link
Contributor Author

Mairu commented Nov 4, 2023

I also have just the information from this PR.
marcelklehr
marcelklehr approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I have collab rights again 🤷 🎉
@marcelklehr marcelklehr merged commit 0ae171f into nodists:master Nov 19, 2023
@gene-pavlovsky
Copy link

Cool, can you create a new release pls? @marcelklehr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants
@Mairu @antonkallenberg @nullivex @gene-pavlovsky @marcelklehr @ashidaharo @fealebenpae