Rename self.client and new_client - prepare for #72 / #111 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2013 13:23
request novnc#72. The standard Python SocketServer/BaseRequestHandler requires this name.
|
Almost 3 weeks since this pull request, and no objections. Thus, I'm merging this one now. |
astrand
pushed a commit
to astrand/websockify
that referenced
this pull request
Dec 16, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prepare for merging #72 / #111, this pull renames self.client to self.request, and new_client() to new_websocket_client(). This makes the diff between the branches much smaller, and makes the actual code changes more visible.