Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and add warning for 'nvm is not compatible with the npm config "prefix" option' edgecase error on Mac OS #2263

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

mkarajohn
Copy link
Contributor

@mkarajohn mkarajohn commented Jul 20, 2020

Fixes #2261

My first thought was to somehow compare the capitalisation between the user directory name displayed from $HOME and the one you'd get from an ls /Users/, but that exceeds my bash scripting skills 😅

So all I did was add an extra subsection in the macOS Troubleshooting section of the docs, and also add an extra warning when that error appears, if we are on a Mac machine.

I also made a small update to the .gitignore file.

@mkarajohn mkarajohn force-pushed the master branch 3 times, most recently from 7039705 to 734591a Compare July 30, 2020 12:38
.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
nvm.sh Outdated Show resolved Hide resolved
@mkarajohn mkarajohn force-pushed the master branch 2 times, most recently from 967b446 to 894d52d Compare August 3, 2020 14:37
mkarajohn added a commit to mkarajohn/nvm that referenced this pull request Aug 3, 2020
mkarajohn added a commit to mkarajohn/nvm that referenced this pull request Aug 3, 2020
Though previous spelling is technically not wrong 🇬🇧
@mkarajohn
Copy link
Contributor Author

All proposed changes were made 🎉

@mkarajohn mkarajohn requested a review from ljharb August 3, 2020 14:47
…he npm config "prefix" option' edgecase error on Mac OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment