US dams example dashboard #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
reviewed
May 15, 2024
…q/framework into allison/dams-example
…), Not available adjacent to Poor (to match hazard potential ordering)
…q/framework into allison/dams-example
…q/framework into allison/dams-example
Co-authored-by: Philippe Rivière <fil@rezo.net>
|
LGTM |
Fil
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed version is here: https://observablehq.observablehq.cloud/framework-example-us-dams/
Working version of a new example, with data on dam condition, location, hazard potential, etc. from the National Inventory of Dams.
Still to update:
marginLeft on horizontal bar chart (top left of by-state.md) to adjust if the longest type "Fire Protection, Stock, Or Small Fish Pond" isn't in the top 10 (otherwise too much blank space)(updated label to shorten)Overlapping container on by-state.md search bar (sometimes makes it unclickable)Fix resize issues (e.g. for summary text box)Move search box to top of table (issue with being non-clickable)Add color to the risk grid (hazard + condition counts, square bubble chart). Ideally this would help indicate "worst" scenario when condition = poor and hazardPotential = High, "best" scenario when condition = fair and hazardPotential = Low, and gray / unknown when either condition or hazardPotential are unknown. Not sure how to accomplish this.(only based on condition, maybe add different scheme later on)Stroke around capital textCondition order in yearCompleted histogram