Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix descender clip #1448

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix descender clip #1448

merged 1 commit into from
Jun 11, 2024

Conversation

mbostock
Copy link
Member

Applies a bit of padding (in addition to margin) so the background extends below the descenders. Also moves the styles to the end of the index.md so that it’s a bit friendlier to edit the example index.md (without getting distracted by some elaborate CSS).

Before:
Screenshot 2024-06-10 at 4 49 29 PM

After:
Screenshot 2024-06-10 at 4 49 12 PM

@mbostock mbostock requested a review from Fil June 10, 2024 23:50
@mbostock mbostock enabled auto-merge (squash) June 10, 2024 23:51
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbostock mbostock merged commit 423d1a5 into main Jun 11, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/fix-descender-clip branch June 11, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants