Events: Add from and to scene names to transition events #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These scene names are missing to make these events useful for anything other than monitoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As stated in #983 the v5 transition events are lacking a severe amount of data rendering them pretty much useless without having your own state (that desyncs the moment you have two clients)
Motivation and Context
The missing from and to scenes on the transition events is what's keeping me on v4. When this PR is released I will be able to switch off v4 and use v5.
It would fix #983 but currently the duration is missing so it's not fixed completely.
How Has This Been Tested?
Tested OS(s):
Types of changes
Checklist:
masteror arelease/*branch.