Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC: Fix FFmpeg opus audio noisy issue. v5.0.195 v6.0.95 #3845

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

xiaozhihong
Copy link
Collaborator

@xiaozhihong xiaozhihong commented Oct 19, 2023

Follow the example in FFmpeg's doc, before calling the API avcodec_send_frame, always use av_frame_alloc to create a new frame.


Co-authored-by: Haibo Chen 495810242@qq.com

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Oct 19, 2023
@xiaozhihong
Copy link
Collaborator Author

Please apply the PR, remove obj dir, and use --ffmpeg-opus=on to configure, ensuring the audio play is not noisy.

@winlinvip winlinvip changed the title RTC: Fix FFmpeg opus audio noisy issue Oct 21, 2023
@winlinvip winlinvip added the RefinedByAI Refined by AI/GPT. label Oct 21, 2023
@winlinvip winlinvip changed the title RTC: Fix FFmpeg opus audio noisy issue. v5.0.194 v6.0.94 Oct 21, 2023
@winlinvip
Copy link
Member

winlinvip commented Oct 25, 2023

The default configuration for version 6.0 is --ffmpeg-opus=on, while for version 5.0, it's --ffmpeg-opus=off. Please handle this when merging.

TRANS_BY_GPT4

@winlinvip winlinvip changed the title RTC: Fix FFmpeg opus audio noisy issue. Oct 25, 2023
@winlinvip winlinvip merged commit 9238f09 into ossrs:develop Oct 25, 2023
5 of 16 checks passed
winlinvip pushed a commit that referenced this pull request Oct 25, 2023
Follow the example in FFmpeg's doc, before calling the API
`avcodec_send_frame`, always use `av_frame_alloc` to create a new frame.

---------

Co-authored-by: Haibo Chen <495810242@qq.com>
duiniuluantanqin added a commit to duiniuluantanqin/srs that referenced this pull request Oct 27, 2023
Follow the example in FFmpeg's doc, before calling the API
`avcodec_send_frame`, always use `av_frame_alloc` to create a new frame.

---------

Co-authored-by: Haibo Chen <495810242@qq.com>
chundonglinlin added a commit to chundonglinlin/srs that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English. RefinedByAI Refined by AI/GPT.
3 participants