Fixes Group Chat Issue (NIP-28) on bundle #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohager
commented
Jun 8, 2023
| @@ -1,6 +1,8 @@ | |||
| .idea | |||
ohager
commented
Jun 8, 2023
| .DS_Store | ||
| node_modules | ||
| /build | ||
| /dist |
ohager
commented
Jun 8, 2023
| "scripts": { | ||
| "dev": "vite dev", | ||
| "build": "svelte-kit sync && svelte-package", | ||
| "bundle": "rimraf ./public && NODE_ENV=production rollup -c", |
There was a problem hiding this comment.
making other people lives easier ;)
ohager
commented
Jun 8, 2023
| @@ -40,7 +37,6 @@ export default { | |||
| plugins: [tailwindcss(), autoprefixer()], | |||
| }, | |||
| }), | |||
| vitePreprocess(), | |||
ohager
commented
Jun 8, 2023
| @@ -248,7 +248,7 @@ | |||
|
|
|||
| <div class=" | |||
| bg-purple-700 text-white | |||
| -mx-4 -mt-5 mb-3 | |||
| -mx-5 -mt-5 mb-3 | |||
There was a problem hiding this comment.
-mx-4 caused minor issues in my app...
ohager
commented
Jun 8, 2023
| @@ -311,7 +311,7 @@ | |||
| {/if} | |||
| {/if} | |||
|
|
|||
| <div id="messages-container" class="overflow-auto -mx-4 px-4" style="height: 50vh; min-height: 300px;"> | |||
| <div id="messages-container" class="overflow-auto -mx-4 px-4 relative top-[-12px] mb-[-20px]" style="height: calc(50vh + 12px); min-height: 300px;"> | |||
There was a problem hiding this comment.
chat window should now fit pixel-perfectly (tested chrome, brave, and firefox)
ohager
commented
Jun 8, 2023
| <div class=" | ||
| fixed bottom-5 right-5 mb-5 flex flex-col item-end font-sans | ||
| "> | ||
| <div id="nostri-chat" class="fixed bottom-5 right-5 mb-5 flex flex-col item-end font-sans"> |
|
We are waiting for the merge in hope, this will resolve "GROUP" chat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5
Additional improvements:
npm run bundle