Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI installing latest typescript #161

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

nicholas-l
Copy link
Contributor

Currently the latest typescript is installed without a package-lock.json file. This file should be checked in so that the whole dependency tree is deterministic (see: https://nodejs.dev/learn/the-package-lock-json-file). Dont worry as this package-lock will not be used by npm when this package is used as a dependency in other packages.
This PR pins typescript to 4.3.x as typescript 4.4 has a semi-breaking change where they change catch argument from error to unknown (see: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables).

@nicholas-l nicholas-l changed the title Fix CI instlaling latest typescript Nov 28, 2021
@nicholas-l
Copy link
Contributor Author

I have also created another PR so that dependency updates to package.json and package-lock.json are automated by dependabot: #162 now that the dependencies are locked.

@nicholas-l
Copy link
Contributor Author

I think Test (ubuntu-latest, 13.x) check is never going to complete as it isn't in the test matrix, and it is marked as required. I believe you can remove this required test in the branch protection rules.

@jasnell jasnell merged commit 814d7a0 into piscinajs:current Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants