Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix picker support in BasicMaterial #6672

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[Fix] Fix picker support in BasicMaterial #6672

merged 1 commit into from
Jun 7, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 7, 2024 •
edited
Loading

  • before the shader worked as a picker, as it used the same vec4 uColor; uniform
  • now the picker uses uint meshInstanceId uniform, and so add support for it to basic shader generator
  • fixes picking Zones gizmos in the Editor
@mvaligursky mvaligursky self-assigned this Jun 7, 2024
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jun 7, 2024
@mvaligursky mvaligursky requested a review from a team June 7, 2024 12:02
@mvaligursky mvaligursky merged commit f880185 into main Jun 7, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-basic-picker branch June 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
2 participants
@mvaligursky @willeastcott